public int getMax(int[] thearray)
{
int max = 0;
for (int i = 1; i != thearray[max]; )
{
max = i;
}
return thearray[max];
}
//Your (and mine too) one stop shop for all C# .Net and JavaScript code snippets;
Errrrh, the code above isn't even valid C#.
ReplyDeleteChange the "<>" operator to "!=" and add a ";" at the end of the for loop construct. Then you have valid C# code.
However, the snippet will always return 1 or go into infinite loop.
LarsL,
ReplyDeleteThanks for the catch. I am sorry about the typo, and I have corrected the code.
Anonymous,
I do not think that comment you made was appropriate (yes that's my discretion). Please refrain yourself from making such comments in the future. I ONLY welcome constructive critism on my blog.
public void getMaxIndex(int[] thearray)
ReplyDelete{
int k =0;
foreach (int j in thearray)
{
if (j > k)
k = j;
}
Console.WriteLine("The max number in array is:{0}",k);
}
It still isn't corrected, because first of all there is no update to the loop counter, secondly array indices start at 0 rather than 1, thirdly the assignment to 'max' is currently unconditional, and finally you are using a completely nonsensical condition for the loop limit (using the current 'max' position to index into the array and using the value there to grab an index).
ReplyDeleteNor Sivad has nearly correct code: it has a bug in that if the array contains all negative numbers, the result will be 0, which is incorrect. This code uses the modern looping idiom, too. However, it does make more sense to return the value rather than display it, and fixing the bug neatly requires a more careful iteration strategy.
You want something like this instead:
public int getMax(int[] thearray)
{
// Throws NullReferenceException if thearray is null
// Throws IndexOutOfRangeException if thearray is zero length
int max = thearray[0];
for (int i = 1; i != thearray.Length; ++i)
{
if (thearray[i] > max) { max = thearray[i]; }
}
return max;
}
This is some serious dailyWTF material!
ReplyDeleteBetter is something like that. (.NET 3.5)
ReplyDeletepublic int getMax(int[] arr)
{
return arr.Max();
}
Dirk: finally nice and elegant solution instead inventing a wheel again, thx
ReplyDeletenice post
ReplyDeletehttp://csharptalk.com
The better solution is the Dirk's one.
ReplyDeleteBut in 2.0 I use:
public int getMax(int[] arr)
{
int max = 0;
foreach(int val in arr)
max = Math.Max(max, val);
return max;
}
2 anonimo viaggiatore
ReplyDeletewhat if 'arr' contains negatives only? =)
Hi Try this,
ReplyDeletepublic static double getMax(double[] valArray)
{
double? max = null;
foreach (double val in valArray)
{
string minus = string.Empty;
double actualVal = val;
if (val.ToString().IndexOf("-") != -1)
{
minus = "-";
actualVal = Convert.ToDouble(val.ToString().Replace("-", ""));
}
max = Math.Max(max.GetValueOrDefault(), actualVal);
max = Convert.ToDouble(minus + max.Value.ToString());
}
return max.GetValueOrDefault();
}
The above code will provide the max value from an array does not matter about negative or positive.
Hi,
ReplyDeleteIgnore my previous post and try this.
The below code will provide the max value from an array does not matter about negative or positive.
public static double getMax(double[] valArray)
{
double? max = valArray[0];
foreach (double val in valArray)
{
max = Math.Max(max.GetValueOrDefault(), val);
}
return max.GetValueOrDefault();
}